✨ (go/v4): Add optional kubectl context locking for e2e tests #5336
+216
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
add-e2e-context
branch
from
049342e to
aa0c6e4
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
add-e2e-context
branch
2 times, most recently
from
e664caa to
c8fa24a
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@mandarjog could you please give a look on this one? |
camilamacedo86
force-pushed
the
add-e2e-context
branch
from
c8fa24a to
1df6ec6
Compare
E2E tests now support optional context locking via KUBE_CONTEXT environment variable. When set, tests validate and lock to the specified kubectl context, preventing context switching during execution. Features: - Display current kubectl context at test startup - Validate context matches KUBE_CONTEXT if set - Add --context flag to all kubectl commands when locked - 100% backward compatible (opt-in feature) Usage: KUBE_CONTEXT=kind-test make test-e2e This addresses feedback from PR kubernetes-sigs#5329 about preventing inadvertent context switching during test execution, while maintaining ease of use (works without any env vars by default). Assisted-by: Cursor
camilamacedo86
force-pushed
the
add-e2e-context
branch
from
1df6ec6 to
cd07c62
Compare
Member
Author
|
/test pull-kubebuilder-e2e-k8s-1-34-0 |
Contributor
vitorfloriano
left a comment
vitorfloriano
left a comment
There was a problem hiding this comment.
Doesn't kubectl validate available contexts based on kubeconfig?
I mean, if we only pass KUBE_CONTEXT to the --context flag in the command without setting this new context first in kubeconfig using kubectl config set-context first, wouldn't that cause an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests now support optional context locking via KUBE_CONTEXT environment
variable. When set, tests validate and lock to the specified kubectl context,
preventing context switching during execution.
Features:
Usage:
KUBE_CONTEXT=kind-test make test-e2e
This addresses feedback from PR #5329 about preventing inadvertent context
switching during test execution, while maintaining ease of use (works without
any env vars by default).
Closes: #5335
Co-Author: @Sijoma