🐛 (helm/v2-alpha): Fix force option to overwriten all files less Chart.yaml #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yaml Chart.yaml contains user-managed version metadata and should never be overwritten, even with --force. The --force flag now regenerates all other preserved files (values.yaml, _helpers.tpl, .helmignore, test-chart.yml) while respecting Chart.yaml. Added integration tests to verify force flag behavior and Chart.yaml preservation.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
Author
|
/test pull-kubebuilder-e2e-k8s-1-33-0 |
Member
Author
|
I am moving forward with this one to unblock the releae since this one is just a small fix for the force |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chart.yaml contains user-managed version metadata and should never be overwritten, even with --force. The --force flag now regenerates all other preserved files (values.yaml, _helpers.tpl, .helmignore, test-chart.yml) while respecting Chart.yaml.
Added integration tests to verify force flag behavior and Chart.yaml preservation.