-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Make sure ResetOpenAPI() is called in tests, even if the tests failed #5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make sure ResetOpenAPI() is called in tests, even if the tests failed #5923
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsekine354 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tsekine354. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @tsekine354!
Your code change looks good to me, but I don't think this change on go.work.sum
should be present, as there are no new libraries in api/krusty/openapicustomschema_test.go
that would justify a change to go.work.sum
.
Could you please try rebasing your branch?
…atch (#1) * Add testcases to reproduce kubernetes-sigs#5878, testing CRD OpenApi extensions * Add x-kubernetes-list-type CRD extension support
This reverts commit 1b27dca.
…esult relied on another PR (#7)
…even if those tests failed
10ecc6f
to
4ef77e1
Compare
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5cd69cd
to
7491159
Compare
/label tide/merge-method-squash |
/lgtm |
/ok-to-test |
ResetOpenAPI()
was called withoutdefer ...
, meaning it won't be called iftest()
fails. It's fine if all tests passed. But if there are any changes which cause failures on those tests, it could also cause test failures in other unrelated tests.FIX: #5922