-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: Propagate Namespace correctly to Helm #5940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Skaronator The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Skaronator! |
Hi @Skaronator. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@koba1t Could you please take a look on this and do |
hi @ncapps @varshaprasad96 @koba1t this PR addresses a bugfix for #5566 , which is a highly upvoted issue at the moment. It’s been open for a while, so could we please review and prioritize it? Thanks! |
Summary
This PR introduces a bugfix for issue #5566, which is currently the 6th most upvoted issue in the Kustomize repository.
Bugfix Details
The fix modifies how
namespace
values are handled withinkustomization.yaml
when usinghelmCharts
:namespace
is set at the top level of thekustomization.yaml
, it will always be propagated to the Helm CLI command.helmCharts
entry specifies its ownnamespace
, that value takes precedence and overrides the top-level one.NamespaceTransformer Behavior
Additionally, the
NamespaceTransformer
will now skip all manifests generated by Helm charts. This aligns with the principle that Helm charts should manage their own namespaces internally.This change also enables charts to deploy resources across multiple namespaces—an essential capability for many popular charts such as the
cert-manager
Helm chart, which installs RBAC resources into thekube-system
namespace.