Skip to content

fix: Propagate Namespace correctly to Helm #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skaronator
Copy link

Summary

This PR introduces a bugfix for issue #5566, which is currently the 6th most upvoted issue in the Kustomize repository.

Bugfix Details

The fix modifies how namespace values are handled within kustomization.yaml when using helmCharts:

  • If a namespace is set at the top level of the kustomization.yaml, it will always be propagated to the Helm CLI command.
  • However, if a helmCharts entry specifies its own namespace, that value takes precedence and overrides the top-level one.

NamespaceTransformer Behavior

Additionally, the NamespaceTransformer will now skip all manifests generated by Helm charts. This aligns with the principle that Helm charts should manage their own namespaces internally.

This change also enables charts to deploy resources across multiple namespaces—an essential capability for many popular charts such as the cert-manager Helm chart, which installs RBAC resources into the kube-system namespace.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skaronator
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Skaronator!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Skaronator. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2025
@Skaronator
Copy link
Author

@koba1t Could you please take a look on this and do /ok-to-test command? Most of the CI Jobs already run anyway but tide and kustomize-presubmit-master are stuck - not sure why.

@prnv30
Copy link

prnv30 commented Aug 10, 2025

hi @ncapps @varshaprasad96 @koba1t this PR addresses a bugfix for #5566 , which is a highly upvoted issue at the moment. It’s been open for a while, so could we please review and prioritize it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants