fix fnplugin storagemounts validation #5942
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes the path-scope validation for bind mounts.
The current implementation validates that mount paths are under the current kustomization directory with
strings.HasPrefix(filepath.Clean(mount.Src), "../")
butfilepath.Clean("../")
returns".."
so the check doesn’t work whenmounts.src
is exactly"../"
like
https://go.dev/play/p/7YfrHGwOKnf
Other considerations
The current implementation lets '../' pass, so running
kustomize build subdir
instead ofkustomize build .
can read files in the current working directory—that is, the parent of the kustomization file—yet even this unintended reach justifies a fix.