Skip to content

Document sourceValue for replacements. #5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document sourceValue for replacements. #5974

wants to merge 1 commit into from
+4 −1

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Aug 29, 2025

The field was introduced in #5630 but not documented.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VannTen
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2025
stormqueen1990
stormqueen1990 reviewed Sep 14, 2025
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @VannTen! Thanks for your contribution!

I just found a minor typo, other than that LGTM.

/lgtm

site/content/en/docs/Reference/API/Kustomization File/replacements.md Outdated
| -----------: | :----: | ----------- | ---- |
| `source`| ✔️ | The source of the value |
| `source`| | The source of the value |
| `sourceValue`| | The litteral value to use as source |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: there's an extra "t" in literal here.

Suggested change
| `sourceValue`| | The litteral value to use as source |
| `sourceValue`| | The literal value to use as source |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, not sure how it got there 😆

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

1 more reviewer

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stormqueen1990 stormqueen1990

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VannTen @k8s-ci-robot @stormqueen1990