Skip to content

Conversation

willbuckner
Copy link

Fixes #5979

When malformed YAML creates resource paths like "../../base - ../../shared/prod", FileLoader.New() was silently resolving these to existing ancestor directories through path normalization instead of failing appropriately. This could cause resources to be loaded from unintended locations, which can be especially dangerous in CI/CD environments.

Added validation in FileLoader.New() to check directory existence before allowing path normalization, preventing the silent "ancestor snapping" behavior.

Before:

=== RUN   TestNewLoaderMalformedPath
    fileloader_test.go:223:
        	Error Trace:	/Users/wbuckner/dev/kustomize/api/internal/loader/fileloader_test.go:223
        	Error:      	"must build at directory: not a valid directory: '/shared/prod' doesn't exist" does not contain "does not exist"
        	Test:       	TestNewLoaderMalformedPath
--- FAIL: TestNewLoaderMalformedPath (0.00s)
FAIL
FAIL	sigs.k8s.io/kustomize/api/internal/loader	0.757s
FAIL

After:

=== RUN   TestNewLoaderMalformedPath
--- PASS: TestNewLoaderMalformedPath (0.00s)
PASS
ok  	sigs.k8s.io/kustomize/api/internal/loader	(cached)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 5, 2025
Copy link

linux-foundation-easycla bot commented Sep 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: willbuckner / name: Will Buckner (0767f90)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @willbuckner!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @willbuckner. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from koba1t September 5, 2025 19:04
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willbuckner
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 5, 2025
When malformed YAML creates resource paths like `"../../base - ../../shared/prod"`,
`FileLoader.New()` was silently resolving these to existing ancestor directories
through path normalization instead of failing appropriately. This could cause
resources to be loaded from unintended locations, which can be especially dangerous
in CI/CD environments (kubernetes-sigs#5979).

Added validation in `FileLoader.New()` to check directory existence before
allowing path normalization, preventing the silent "ancestor snapping" behavior.

Before:
```
=== RUN   TestNewLoaderMalformedPath
    fileloader_test.go:223:
        	Error Trace:	/Users/wbuckner/dev/kustomize/api/internal/loader/fileloader_test.go:223
        	Error:      	"must build at directory: not a valid directory: '/shared/prod' doesn't exist" does not contain "does not exist"
        	Test:       	TestNewLoaderMalformedPath
--- FAIL: TestNewLoaderMalformedPath (0.00s)
FAIL
FAIL	sigs.k8s.io/kustomize/api/internal/loader	0.757s
FAIL
```

After:
```
=== RUN   TestNewLoaderMalformedPath
--- PASS: TestNewLoaderMalformedPath (0.00s)
PASS
ok  	sigs.k8s.io/kustomize/api/internal/loader	(cached)
```
@willbuckner willbuckner force-pushed the fix-malformed-yaml-resource-paths branch from 5e93cdc to 0767f90 Compare September 5, 2025 19:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 5, 2025
@koba1t
Copy link
Member

koba1t commented Sep 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2025
@koba1t
Copy link
Member

koba1t commented Sep 29, 2025

Hi @willbuckner
I think this PR is worth introducing.

Please fix tests that happen on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed resources YAML entry silently resolves to wrong directory (../../shared/prod) instead of erroring

3 participants