Conversation
✅ Deploy Preview for kubernetes-sigs-lws ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TaeSooRhee-moreh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @TaeSooRhee-moreh! |
|
Hi @TaeSooRhee-moreh. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it
As we can see from the examples, we usually require services for leaders.
Therefore, we can make LeaderService as "[LWS name]-leader" with leaderServicePorts at CR.
Which issue(s) this PR fixes
Fixes #689
Special notes for your reviewer
Does this PR introduce a user-facing change?
NONE