Skip to content

[WIP]Fix Failing Tests in kube 1.35#752

Open
yankay wants to merge 1 commit intokubernetes-sigs:mainfrom
yankay:fix-Failing-1.35
Open

[WIP]Fix Failing Tests in kube 1.35#752
yankay wants to merge 1 commit intokubernetes-sigs:mainfrom
yankay:fix-Failing-1.35

Conversation

@yankay
Copy link
Member

@yankay yankay commented Feb 4, 2026

What type of PR is this?

/kind failing-test

What this PR does / why we need it

TODO

Which issue(s) this PR fixes

ref kubernetes/kubernetes#133153
Fixes #751

Special notes for your reviewer

Does this PR introduce a user-facing change?


Copilot AI review requested due to automatic review settings February 4, 2026 12:21
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Feb 4, 2026
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit d06f3e6
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-lws/deploys/698591ee970efd0008aceedf

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yankay
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Kubernetes-related Go module dependencies to address failing tests when running against Kubernetes 1.35.

Changes:

  • Bumps sigs.k8s.io/controller-runtime from v0.23.0 to v0.23.1.
  • Bumps sigs.k8s.io/structured-merge-diff/v6 from v6.3.1 to v6.3.2-0.20260122202528-d9cc6641c482.
  • Updates go.sum entries to align with the new dependency versions.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates controller-runtime and structured-merge-diff dependencies to newer versions compatible with Kubernetes 1.35.
go.sum Synchronizes checksum entries with the updated dependency versions from go.mod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yankay yankay force-pushed the fix-Failing-1.35 branch 2 times, most recently from 7c94439 to 58b849a Compare February 5, 2026 03:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2026
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 6, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 6, 2026

@yankay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lws-test-e2e-main-cert-manager d06f3e6 link true /test pull-lws-test-e2e-main-cert-manager
pull-lws-test-e2e-main-1-35 d06f3e6 link true /test pull-lws-test-e2e-main-1-35

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yankay
Copy link
Member Author

yankay commented Feb 9, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing 1.35 e2e tests

3 participants