Fix: staging image in production installation#784
Fix: staging image in production installation#784panpan0000 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: panpan0000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-lws ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @panpan0000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it
When follow the doc, to downloading manifests from the release page and running:
The controller image points to the staging registry (
us-central1-docker.pkg.dev/k8s-staging-images/lws/lws:v0.8.0) instead of the officialregistry.k8s.io/lws/lws:v0.8.0.Root cause:
The
clean-manifestsfunction in the Makefile hardcodes the staging registry:This function is called by both
prepare-release-branchandartifactstargets. It revertsconfig/manager/kustomization.yamlto the staging image after building the release artifacts, and this gets committed to the release branch.Fix:
Change
clean-manifeststo useregistry.k8s.iowith the defaultmaintag:This ensures the kustomization file always points to the official registry after building artifacts.
Test results:
This does not affect local development - developers still work with the staging registry by default when building locally.