Relax criteria for the "Local service not impacted" E2E test #121
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been failing intermittently for a while:
STEP: verifying a local, unexported service is reachable via cluster.local
[FAILED] Timed out after 10.092s.
There is no failure as the matcher passed to Eventually succeeded on its
most recent iteration
In [It] at: .../mcs-api/e2e/localserviceimpact_test.go:167
So the Eventually in checkAllClustersReachable:
Eventually(func(g Gomega) {
...
}, "10s").MustPassRepeatedly(50).Should(Succeed())
does succeed but sometimes does not do so 50 times within 10s. So we
need to relax these criteria, either increase the timeout or decrease
the number of times. I opted for the latter, ie 20 times.
Signed-off-by: Tom Pantelis <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
/cc @MrFreezeex |
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex, tpantelis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing intermittently for a while:
So the
EventuallyincheckAllClustersReachable:does succeed but sometimes does not do so 50 times within 10s. I don't know why these specific values were chosen but it seems we need to relax these criteria, either increase the timeout or decrease the number of times. I opted for the latter, ie 20 times.