Use repository default branch in chart-testing workflow #1684
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-triage
Member
Author
|
/assign @dgrisonnet |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: RainbowMango <[email protected]>
RainbowMango
force-pushed
the
pr_bump_helm_chart_testing_action
branch
from
0bb1bdf to
2e8202d
Compare
k8s-ci-robot
removed
the
needs-rebase
Member
Author
|
/retitle Use repository default branch in chart-testing workflow |
k8s-ci-robot
changed the title
Member
Author
|
Updated PR title and description. |
Member
|
/assign |
k8s-ci-robot
added
triage/accepted
Member
Author
|
@dgrisonnet I guess this is ready to go. |
TerryHowe
approved these changes
Sep 27, 2025
Member
TerryHowe
left a comment
TerryHowe
left a comment
There was a problem hiding this comment.
A nicer solution than the hard coded branch name
github-project-automation
bot
moved this from Needs Review (PR) or Response (Issue)
to In Progress
in SIG Instrumentation
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, RainbowMango, TerryHowe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
/test pull-metrics-server-test-e2e-helm |
github-project-automation
bot
moved this from In Progress
to Done
in SIG Instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bump helm/chart-testing-action to v2.7.0, to replace #1638 as explained at #1638 (comment)This PR updates the
.github/workflows/lint-test-chart.yamlworkflow to use the repository’s default branch(${{ github.event.repository.default_branch }})instead of hardcodingmasteras the target branch for chart-testing commands. This change improves compatibility for repositories that use a different default branch name (such asmain), making the workflow more flexible and future-proof.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #