-
Notifications
You must be signed in to change notification settings - Fork 2k
helm-release: Publish the helm chart as OCI artifact #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
helm-release: Publish the helm chart as OCI artifact #1734
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcofranssen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @marcofranssen! |
|
Hi @marcofranssen. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR will ensure whenever a new release of the chart is published it will also be published as OCI.
the chart will be published at
ghcr.io/kubernetes-sigs/charts/metrics-serverThis is useful for folks that use ECR caching in local regions for faster argocd syncs.
Same is used for couple of years here https://github.com/spiffe/helm-charts-hardened/blob/spire-0.26.1/.github/workflows/helm-release.yaml#L53-L70
Also see kubernetes-sigs/cluster-proportional-autoscaler#268
Note
As the original helm release isn't touched that part of the release will not be affected. Only if the http release succeeds the workflow will try to also publish this OCI release.
The risk therefore is very low.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):N.A.