Skip to content

Conversation

@Serializator
Copy link

What this PR does / why we need it:
Annotations in the APIService template are rendered as null when:

  • .Values.tls.certManager.addInjectorAnnotations is set to true
  • .Values.tls.type is not equal to "cert-manager"

This PR extends the conditional with the same .Values.tls.type check to avoid rendering annotations as null.

Which issue(s) this PR fixes:
Fixes #1689

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Instrumentation Jan 15, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Serializator. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2026
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Serializator. Could you please add a chart CHANGELOG entry?

@github-project-automation github-project-automation bot moved this from Needs Triage to In Progress in SIG Instrumentation Jan 20, 2026
@Serializator Serializator force-pushed the ISSUE-1689-annotations-null branch from 89cc8ca to 21a8b76 Compare January 20, 2026 19:49
@Serializator
Copy link
Author

Serializator commented Jan 20, 2026

👍🏼 Added to the changelog @stevehipwell

@stevehipwell
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2026
@stevehipwell
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2026
@stevehipwell
Copy link
Contributor

@yangjunmyfm192085 do you want to add the LGTM?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Serializator, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@Serializator
Copy link
Author

@yangjunmyfm192085 do you have the time to take a peek at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

ArgoCD: periodic sync since helm 3.13.0: annotations are null

3 participants