-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(chart): do not render annotations as null in APIService template #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(chart): do not render annotations as null in APIService template #1752
Conversation
|
Hi @Serializator. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Serializator. Could you please add a chart CHANGELOG entry?
89cc8ca to
21a8b76
Compare
Signed-off-by: Julian van den Berkmortel <[email protected]>
21a8b76 to
e6ab860
Compare
|
👍🏼 Added to the changelog @stevehipwell |
|
/ok-to-test |
|
/triage accepted |
|
@yangjunmyfm192085 do you want to add the LGTM? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Serializator, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yangjunmyfm192085 do you have the time to take a peek at this PR? |
What this PR does / why we need it:
Annotations in the APIService template are rendered as
nullwhen:.Values.tls.certManager.addInjectorAnnotationsis set totrue.Values.tls.typeis not equal to"cert-manager"This PR extends the conditional with the same
.Values.tls.typecheck to avoid rendering annotations asnull.Which issue(s) this PR fixes:
Fixes #1689