Skip to content

Collect swap usage metrics for nodes and containers #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Serializator wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Collect swap usage metrics for nodes and containers #1753

Serializator wants to merge 6 commits into from

Conversation

@Serializator
Copy link

@Serializator Serializator commented Jan 17, 2026

What this PR does / why we need it:
Report on swap usage metrics to allow kubectl top node --show-swap and kubectl top pod --show-swap to properly report swap usage of nodes and containers.

Which issue(s) this PR fixes:
Fixes #1680

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Serializator
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2026

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2026

Hi @Serializator. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Instrumentation Jan 17, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2026
@Serializator
test(decode): rename single node to single container to correctly rep…
2725e6e 
…resent test case

Signed-off-by: Julian van den Berkmortel <[email protected]>
@Serializator
feat(storage): add struct property to MetricsPoint to represent swap …
6df9c73 
…usage

Signed-off-by: Julian van den Berkmortel <[email protected]>
@Serializator
test(decode): add swap usage to single container and single node test…
6089111 
… case

Signed-off-by: Julian van den Berkmortel <[email protected]>
@Serializator
feat(decode): parse container_swap_usage_bytes and node_swap_usage_by…
fc50d57 
…tes metrics
@Serializator
test(storage): add swap usage to resource usage test case
33e1d9d 
Signed-off-by: Julian van den Berkmortel <[email protected]>
@Serializator
feat(storage): add swap to resource usage
debfd31 
Signed-off-by: Julian van den Berkmortel <[email protected]>
@Serializator Serializator force-pushed the ISSUE-1680-swap-usage branch from 0c5886a to debfd31 Compare January 30, 2026 22:14
@Serializator
Copy link
Author

Serializator commented Feb 4, 2026

Hey @dgrisonnet & @RainbowMango! Would you have some time to look at this PR? Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Instrumentation
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collect swap usage via the container_swap_usage_bytes metric

2 participants

@Serializator @k8s-ci-robot