-
Notifications
You must be signed in to change notification settings - Fork 27
✨ Add multi provider #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will need squashing but I'll do that after reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits.
I haven't followed all discussions in the sig sorry, but would it be possible to modify the manager to allow mulitple providers in the first place? |
I think so, this here would give us a way to experiment and iterate on the design without breaking anything for users of multicluster-runtime not interested in running multiple providers. So I think it might be the more elegant design, helping us explore the versatility of the provider interface further. |
383dd34
to
2417997
Compare
Signed-off-by: Nelo-T. Wallus <[email protected]>
Add the
multi
provider, allowing to use multiple providers with a single manager without conflicting cluster names.Pseudo to instantiate: