✨ Update to sigs.k8s.io/controller-runtime v0.22.0 #69
+584
−554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
embik
force-pushed
the
controller-runtime-0.22.0
branch
from
92795f6 to
4675675
Compare
k8s-ci-robot
removed
the
needs-rebase
embik
force-pushed
the
controller-runtime-0.22.0
branch
from
4675675 to
a9d7c0c
Compare
k8s-ci-robot
added
size/XXL
Member
Author
|
/cc @mjudeikis @sttts could I get a review on this one? |
k8s-ci-robot
added
the
needs-rebase
mjudeikis
reviewed
Oct 3, 2025
Collaborator
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
/lgtm
rebase and will tag. Overall - not much review can be done on bunch of go.mod files. it either works or does not with the updated deps :)
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 13b17f9faf197f757cdea1d49d5b29c8515dfba0
|
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
controller-runtime-0.22.0
branch
from
a9d7c0c to
2f939c0
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 42ec94d148fc72f9871ab8bdee1dbf2c5a2eaff9
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest (triggering prow to re-check CI status) |
embik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a fairly straightforward update. Most of the PR is adopting changes from kubernetes-sigs/controller-runtime#3263 into our forked tests.