npep-187: More protocols support #297
Conversation
Signed-off-by: Nadia Pinaeva <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: npinaeva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
High level looks ok to me plus aligns with what was discussed. /lgtm |
k8s-ci-robot
added
the
lgtm
| ``` | ||
|
|
||
| with the validation like so: | ||
| - empty `protocols` list is not allowed |
There was a problem hiding this comment.
Clarification: this is having just protocols: but no list?
| with the validation like so: | ||
| - empty `protocols` list is not allowed | ||
| - at least 1 field for each `protocol` element must be set | ||
| - if `namedPort` is set, `protocol` must be unset |
There was a problem hiding this comment.
I think we were thinking to not have namedPort for the first pass?
|
How do we make progress on this? |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Issue: #187
TODO: also reference #247 when we are closer to the API design