Skip to content

Update site documentation of NPEP-133 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update site documentation of NPEP-133 #301

wants to merge 3 commits into from
+9 −8

Conversation

siegenthalerroger
Copy link

@siegenthalerroger siegenthalerroger commented Jun 11, 2025 •
edited
Loading

  • Enhance contributor documentation by including all necessary mkdocs plugins and ensuring compatibility with paths containing spaces.

  • Update the sidebar with new NPEP-133 status (implementable).

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 11, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented Jun 11, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit bb8ac0a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-network-policy-api/deploys/685d0a0f4763ae00082d21e4
😎 Deploy Preview https://deploy-preview-301--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: siegenthalerroger
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and astoycos June 11, 2025 14:59
@k8s-ci-robot
Copy link
Contributor

Welcome @siegenthalerroger!

It looks like this is your first PR to kubernetes-sigs/network-policy-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/network-policy-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @siegenthalerroger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 11, 2025
bowei
bowei reviewed Jun 13, 2025
View reviewed changes
site-src/npeps/npep-133.md Outdated
@@ -1,173 +0,0 @@
# NPEP-133: FQDN Selector for Egress Traffic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we delete the npep document when they are implementable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so :/

@bowei
Copy link

bowei commented Jun 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2025
@bowei
Copy link

bowei commented Jun 13, 2025

LGTM -- but do we remove the site-src/npeps/ when they turn implementable?

tssurya
tssurya reviewed Jun 17, 2025
View reviewed changes
site-src/npeps/npep-133.md Outdated
@@ -1,173 +0,0 @@
# NPEP-133: FQDN Selector for Egress Traffic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm @siegenthalerroger why did this NPEP get removed?
did you run make docs btw for the src/site changes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it manually as it is no longer available in the /npeps folder. I've reinstated the file now, it is not linked from any place on the site though, so I'm not sure that actually make sense. Is it intended to have the old NPEP version linked as "Experimental" and the new version from "Implementable"? That would seem counter-intuitive to me tbh.

I ran make docs again now and have no changes from that to the /site-src folder (apart from a pycache update, which I assumed I didn't need to commit).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowei @npinaeva see above comment regarding the removal of the old NPEP version from /site-src

@siegenthalerroger siegenthalerroger force-pushed the docs/npep-133-implementable branch from f749ab7 to bb8ac0a Compare June 26, 2025 08:51
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssurya tssurya tssurya left review comments

@npinaeva npinaeva npinaeva left review comments

@aojea aojea Awaiting requested review from aojea

@astoycos astoycos Awaiting requested review from astoycos

+1 more reviewer

@bowei bowei bowei left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siegenthalerroger @k8s-ci-robot @bowei @tssurya @npinaeva