-
Notifications
You must be signed in to change notification settings - Fork 38
CNP update tests #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CNP update tests #307
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: npinaeva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/test all |
a8a80dd
to
59370c2
Compare
.github/workflows/conformance.yml
Outdated
# install kube-network-policies | ||
/usr/local/bin/kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/kube-network-policies/v0.6.1/install-anp.yaml | ||
/usr/local/bin/kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/kube-network-policies/c87e5ec2f503aabe76fc2a53e117d651cf591733/install-cnp.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to replace the image in that manifest by aojea/kube-network-policies:cnp
, download the manifest
wget https://raw.githubusercontent.com/kubernetes-sigs/kube-network-policies/c87e5ec2f503aabe76fc2a53e117d651cf591733/install-cnp.yaml -O install-cnp.yaml
and change the image sed -i s#registry.k8s.io/networking/kube-network-policies.*#aojea/kube-network-policies:cnp# install-cnp.yaml
It is not possible anymore to support ANP or BANP only, there is only one conformance profile now - CNP Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
I have to use a commit hash because the actually tagged release had wrong image references. Signed-off-by: Nadia Pinaeva <[email protected]>
a409b69
to
0718558
Compare
/test all |
After merging a new v1alpha2 API version, our conformance tests should be updated.
This PR removed ANP+BANP conformance tests, but they can still be used by specifying the previous repo version.
It is not possible anymore to support ANP or BANP only, there is only
one conformance profile now - CNP.
Remove ANP and BANP from the standard and experimental channels.
It also uses the latest kube-network-policy implementation of CNP for our conformance testing.
tracking issue #285
follow up for #306