-
Notifications
You must be signed in to change notification settings - Fork 276
Allow unprefixed annotations via feature-gate #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/assign @marquiz |
It might be worth updating the documentation as well...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fmuyassarov for this. Looks good and makes sense to me
It might be worth updating the documentation as well...?
Yes, I don't remember if it's somewhere else (likely not) but at least the customization guide probably needs some update
c672c0f
to
fa5f07c
Compare
Updated accordingly |
/test pull-node-feature-discovery-build-image-cross-generic |
/assign @ArangoGutierrez |
fa5f07c
to
282c905
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements support for unprefixed annotations through a feature gate mechanism, allowing users to control whether annotations are automatically prefixed with the NFD namespace. When the DisableAutoPrefix
feature gate is enabled, unprefixed annotations are allowed without automatic prefixing.
- Adds conditional logic to skip auto-prefixing when the
DisableAutoPrefix
feature gate is enabled - Updates annotation filtering to allow unprefixed annotations when the feature gate is active
- Expands test coverage to verify both prefixed and unprefixed annotation behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
pkg/nfd-master/nfd-master.go | Implements feature gate logic for skipping auto-prefixing and allowing unprefixed annotations |
pkg/nfd-master/nfd-master-internal_test.go | Adds comprehensive test cases for unprefixed annotation handling with feature gate |
docs/usage/customization-guide.md | Updates documentation to clarify unprefixed annotation behavior with feature gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the typos, lgtm
282c905
to
f9c6770
Compare
Signed-off-by: Feruzjon Muyassarov <[email protected]>
f9c6770
to
dcc8e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArangoGutierrez PTAL
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #2120 and is related to #2074.