Skip to content

Conversation

@marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 30, 2025

The biggest change is that the default kubeconfig is the same as for kubeconfig ($HOME/.kube/config) instead of in-cluster config. Makes usage easier as now the --kubeconfig flag is not normally needed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit fa9079b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/690376d7dab3d3000856b852
😎 Deploy Preview https://deploy-preview-2353--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2025
@marquiz marquiz changed the title kubectl-nfd/test: rework kubectl initialization kubectl-nfd/test: rework kubeconfig initialization Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2025
The biggest change is that the default kubeconfig is the same as for
kubeconfig ($HOME/.kube/config) instead of in-cluster config. Makes
usage easier as now the --kubeconfig flag is not normally needed.
@marquiz marquiz force-pushed the devel/kubectl-plugin-kubeconfig branch from 4d1b251 to fa9079b Compare October 30, 2025 14:31
@marquiz
Copy link
Contributor Author

marquiz commented Oct 30, 2025

/assign @fmuyassarov @ArangoGutierrez
/cc @tkatila

@k8s-ci-robot
Copy link
Contributor

@marquiz: GitHub didn't allow me to request PR reviews from the following users: tkatila.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @fmuyassarov @ArangoGutierrez
/cc @tkatila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz
Copy link
Contributor Author

marquiz commented Oct 30, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants