Skip to content

cleanup: Remove unused globalDryRun feature (#123)#130

Open
GGh41th wants to merge 1 commit intokubernetes-sigs:mainfrom
GGh41th:remove-unused-global-dryrun
Open

cleanup: Remove unused globalDryRun feature (#123)#130
GGh41th wants to merge 1 commit intokubernetes-sigs:mainfrom
GGh41th:remove-unused-global-dryrun

Conversation

@GGh41th
Copy link

@GGh41th GGh41th commented Feb 14, 2026

Description

Removing dead code for the GlobalDryRun feature , since it was never used.

Related Issue

Fixes #123

Type of Change

/kind cleanup

Testing

Checklist

  • [ ✓ ] make test passes
  • [ ✓ ] make lint passes

Does this PR introduce a user-facing change?

Doc #(issue)

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 14, 2026
@netlify
Copy link

netlify bot commented Feb 14, 2026 •
edited
Loading

✅ Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit d1076f8
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/699096d02741a600089659d6

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GGh41th
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 14, 2026 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: GGh41th / name: Ghaith Gtari (d1076f8)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2026

Welcome @GGh41th!

It looks like this is your first PR to kubernetes-sigs/node-readiness-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-readiness-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 14, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2026

Hi @GGh41th. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 14, 2026
AvineshTripathi
AvineshTripathi reviewed Feb 15, 2026
View reviewed changes
internal/controller/nodereadinessrule_controller.go
ruleCache map[string]*readinessv1alpha1.NodeReadinessRule // ruleName -> rule

// Global dry run mode (emergency off-switch)
globalDryRun bool
Copy link
Contributor

@AvineshTripathi AvineshTripathi Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while i agree here that it is not implemented in all required places, I think we still should keep this field or at least make a comment to use it whenever we are implementing it across the project. Thoughts? @ajaysundark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tallclair tallclair Awaiting requested review from tallclair

1 more reviewer

@AvineshTripathi AvineshTripathi AvineshTripathi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cleanup: Remove unused globalDryRun feature

3 participants

@GGh41th @k8s-ci-robot @AvineshTripathi