chore: refactor containers to use generics #1535
Open
+42
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
area/release-eng
|
@justinsb can you rebase? |
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
refactor_containers
branch
from
b80c727 to
6b450c0
Compare
k8s-ci-robot
removed
the
needs-rebase
golangci-lint was not happy with the type-safety previously.
justinsb
force-pushed
the
refactor_containers
branch
from
6b450c0 to
6eb0c69
Compare
k8s-ci-robot
added
release-note-none
cpanato
approved these changes
May 13, 2025
There was a problem hiding this comment.
seems good, but i also would like to have another pair of 👁️ on this
/lgtm
/hold
/assign @saschagrunert @puerco
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint was not happy with the type-safety previously.