[WIP]Fix parsing of extravars with multiple fields #57
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishen-v The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/cc @Karthik-K-N for the golang bits. Thanks in advance! |
kishen-v
force-pushed
the
allow-multi-extravars
branch
from
d1ae2c4 to
16c8315
Compare
Rajalakshmi-Girish
left a comment
Rajalakshmi-Girish
left a comment
There was a problem hiding this comment.
@kishen-v What job definitions do you think needs modifications after this?
This search output https://github.com/search?q=repo%3Appc64le-cloud%2Ftest-infra%20extra-vars&type=code is only showing instances where we only variable is passed with --extra-vars flag.
| tasks: | ||
| - set_fact: | ||
| prepull_images: "{{ prepull_images + ['registry.k8s.io/pause:3.10'] }}" | ||
| prepull_images: "{{ (prepull_images | from_json if prepull_images is string else prepull_images) + ['registry.k8s.io/pause:3.10'] }}" |
There was a problem hiding this comment.
Why is this change part of the extravars modification? I might be missing something here. :|
kishen-v
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
3 participants
The current design doesn't parse the complete set of key:value pairs passed to the --extra-vars flag. The implemented approach accepts the vars as a string and performs operations to allow them to be parsed separately.
/hold - Until the PR is approved, as changes need to be done in a few job definitions.