add more wrapper func for tablewriter #139
Merged
+117
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
cpanato
changed the title
cpanato
force-pushed
the
improve-tablewriter
branch
from
1137cf8 to
d23bd79
Compare
k8s-ci-robot
added
the
lgtm
Member
|
CI is unhappy |
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
force-pushed
the
improve-tablewriter
branch
from
d23bd79 to
9eb8ae7
Compare
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
k8s-ci-robot
added
size/L
Member
Author
|
renamed the package utils to helpers to make more meaniful and also to fix the lint issue |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Member
Author
|
already updated a few repos on our side, i think we can move forward |
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
not happy with the initial PR, and this adds some default functions to avoid we pass the entire config when we use it, only if required
follow up of #136
/assign @saschagrunert
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?