Skip to content

Commit b95c9ba

Browse files
committed
fix code review comment
1 parent 39cba30 commit b95c9ba

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

pkg/noderesourcetopology/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,22 +262,22 @@ zones:
262262
$ kubectl get noderesourcetopologies.topology.node.k8s.io
263263
```
264264

265-
2. Alternatively, in case you are just interested in simply testing the scheduler plugin, use the manifest in the manifest directory to deploy the CRD and CRs as follows:
265+
1. Alternatively, in case you are just interested in simply testing the scheduler plugin, use the manifest in the manifest directory to deploy the CRD and CRs as follows:
266266

267267
1. Deploy the Custom Resource Definition manifest
268268

269269
```bash
270270
$ kubectl create -f crd.yaml
271271
```
272272

273-
2. Check if the noderesourcetopologies.topology.node.k8s.io CRD is created
273+
1. Check if the noderesourcetopologies.topology.node.k8s.io CRD is created
274274

275275
```bash
276276
$ kubectl get crd
277277
$ kubectl get noderesourcetopologies.topology.node.k8s.io
278278
```
279279

280-
3. Deploy the CRs representative of the hardware topology of the worker-node-A and worker-node-B if CRs haven't been created using RTE or NFD as mentioned above:
280+
1. Deploy the CRs representative of the hardware topology of the worker-node-A and worker-node-B if CRs haven't been created using RTE or NFD as mentioned above:
281281

282282
```bash
283283
$ kubectl create -f worker-node-A.yaml

pkg/sysched/sysched_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ package sysched
22

33
import (
44
"context"
5-
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
65
"testing"
76

87
"github.com/stretchr/testify/assert"
98
v1 "k8s.io/api/core/v1"
109
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1110
"k8s.io/apimachinery/pkg/runtime"
11+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
1212
"k8s.io/apimachinery/pkg/util/sets"
1313
"k8s.io/client-go/informers"
1414
clientsetfake "k8s.io/client-go/kubernetes/fake"

pkg/trimaran/lowriskovercommitment/lowriskovercommitment.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func (pl *LowRiskOverCommitment) Score(ctx context.Context, cycleState *framewor
112112
klog.V(6).InfoS(err.Error()+"; recalculating", "pod", klog.KObj(pod))
113113
podResources = CreatePodResourcesStateData(pod)
114114
}
115-
// exclude scoring for best effort pods; this plugin is not concerned about the best effort pods
115+
// exclude scoring for best effort pods; this plugin is not concerned about best effort pods
116116
podRequests := &podResources.podRequests
117117
podLimits := &podResources.podLimits
118118
if podRequests.MilliCPU == 0 && podRequests.Memory == 0 &&

pkg/trimaran/resourcestats.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func GetResourceLimits(pod *v1.Pod) *framework.Resource {
121121
})
122122
}
123123

124-
// GetEffectiveResource : calculate effective resources of a pod (CPU and Memory)
124+
// GetEffectiveResource: calculate effective resources of a pod (CPU and Memory)
125125
func GetEffectiveResource(pod *v1.Pod, fn func(container *v1.Container) v1.ResourceList) *framework.Resource {
126126
result := &framework.Resource{}
127127
// add up resources of all containers

0 commit comments

Comments
 (0)