Skip to content

fix merge bug for trimaran peaks #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix merge bug for trimaran peaks #928

wants to merge 1 commit into from
+1 −1

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Aug 10, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

During the 1.33 dependency bump, @googs1025 called out a bad change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

ref: #917 (comment)

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 10, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit f82b2ce
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-scheduler-plugins/deploys/6898cee80220450008d024f7

@kannon92 kannon92 mentioned this pull request Aug 10, 2025
Merged
googs1025
googs1025 reviewed Aug 11, 2025
View reviewed changes
pkg/trimaran/peaks/peaks_test.go
}
assert.ElementsMatch(t, tt.expected, actualList)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for quick fix
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: googs1025, kannon92
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 approved these changes

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

Assignees

@googs1025 googs1025

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kannon92 @k8s-ci-robot @googs1025