-
Notifications
You must be signed in to change notification settings - Fork 124
Add extra field to Abstract AppArmorProfile spec #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @Edan-Hamilton. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2784 +/- ##
===========================================
- Coverage 45.50% 23.57% -21.93%
===========================================
Files 79 119 +40
Lines 7782 20272 +12490
===========================================
+ Hits 3541 4779 +1238
- Misses 4099 15254 +11155
- Partials 142 239 +97 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
CI does not seem to be happy about this: |
Looks like it just wanted a comment above the new field. Fixed |
|
/test all |
|
@Edan-Hamilton Please could you fix the build failure? I think you need to regenerate the deployment manifests with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Edan-Hamilton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Edan-Hamilton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Adds an "extra" field to the Abstract spec, which allows including additional AppArmor parameters. This is important for handling edge-cases not (yet) covered by the spec.
Which issue(s) this PR fixes:
Fixes #2678
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?