Skip to content

Remove FSS block-volume-snapshot #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove FSS block-volume-snapshot #3408

wants to merge 1 commit into from
+33 −331

Conversation

johnchobroadcom
Copy link
Contributor

@johnchobroadcom johnchobroadcom commented Jul 6, 2025 •
edited
Loading

What this PR does / why we need it:

Removes obsolete FSS block-volume-snapshot

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
1.unit tests
2.precheckin:https://jenkins-vcf-csifvt.devops.broadcom.net/view/instapp/job/wcp-instapp-e2e-pre-checkin/171/

Special notes for your reviewer:

Release note:

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: johnchobroadcom / name: John Cho (9c99693)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @johnchobroadcom. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 6, 2025
@johnchobroadcom johnchobroadcom force-pushed the fss_block_vol_snapshot branch from 2146eb6 to 784a24d Compare July 27, 2025 21:57
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnchobroadcom
Once this PR has been reviewed and has the lgtm label, please assign kolluria for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2025
@johnchobroadcom johnchobroadcom force-pushed the fss_block_vol_snapshot branch from 784a24d to 4a26d23 Compare July 29, 2025 17:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025
@johnchobroadcom
Copy link
Contributor Author

@xing-yang not sure who should be reviewing this PR. Can you help assign to the right person? Thanks.

@johnchobroadcom johnchobroadcom mentioned this pull request Jul 30, 2025
Closed
11 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2025
@johnchobroadcom johnchobroadcom force-pushed the fss_block_vol_snapshot branch from 4a26d23 to 9c99693 Compare July 31, 2025 08:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2025
@akankshapanse
Copy link
Contributor

please rerun the precheckin test as the link for earlier result is not accessible now, can you please also paste/attach unittest results

akankshapanse
akankshapanse reviewed Aug 5, 2025
View reviewed changes
manifests/supervisorcluster/1.30/cns-csi.yaml
@@ -556,7 +556,6 @@ data:
"csi-sv-feature-states-replication": "true"
"fake-attach": "true"
"improved-csi-idempotency": "true"
"block-volume-snapshot": "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add same change, missed from manifests/supervisorcluster/1.31/cns-csi.yaml

akankshapanse
akankshapanse reviewed Aug 5, 2025
View reviewed changes
manifests/guestcluster/1.32/pvcsi.yaml
@@ -683,7 +683,6 @@ data:
"online-volume-extend": "true"
"file-volume": "true"
"csi-sv-feature-states-replication": "false" # Do not enable for guest cluster, Refer PR#2386 for details
"block-volume-snapshot": "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query: why did we remove the fss from last n-2 yaml files only? do we want to remove from all earlier ones as well or do we not have any TKR release on older versions ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @chethanv28 , n-2 is apparently the convention CSI team follows for manifest updates. I presume there isn't really a point in updating older versions as code changes would also have to be backported to release branches or tag. You guys shouldn't me asking me this question. :)

akankshapanse
akankshapanse reviewed Aug 5, 2025
View reviewed changes
pkg/syncer/admissionhandler/pvcsi_admissionhandler.go
@@ -126,10 +126,6 @@ func (h *CSIGuestWebhook) Handle(ctx context.Context, req admission.Request) (re

resp = admission.Allowed("")
if req.Kind.Kind == "PersistentVolumeClaim" {
if featureGateBlockVolumeSnapshotEnabled {
admissionResp := validatePVC(ctx, &req.AdmissionRequest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should continue to validate PVC always with featureGateBlockVolumeSnapshotEnabled check removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should continue to validate PVC always with featureGateBlockVolumeSnapshotEnabled check removed

Good catch. Will fix.

akankshapanse
akankshapanse reviewed Aug 5, 2025
View reviewed changes
pkg/syncer/admissionhandler/validatesnapshotoperation_test.go
@@ -1,204 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of deleting entire unittests, we should modify it to cover remaining scenarios that do get exercised in pkg/syncer/admissionhandler/validatesnapshotoperation.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't really sure how to tease apart the test to deal with feature flag going away. Do you want to take a shot at updating the test with this commit; I am probably not going to be able to sort this out without bugging ppl.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

@shalini-b shalini-b Awaiting requested review from shalini-b

1 more reviewer

@akankshapanse akankshapanse akankshapanse left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnchobroadcom @k8s-ci-robot @akankshapanse