Skip to content

tkg win test fix #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2025
Merged

tkg win test fix #3430

merged 1 commit into from
Aug 30, 2025

Conversation

rajguptavm
Copy link
Contributor

@rajguptavm rajguptavm commented Jul 15, 2025 •
edited
Loading

What this PR does / why we need it:
TKG test fix for windows worker

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  1. exec [POD] [COMMAND] is not supported anymore. Use exec [POD] -- [COMMAND] instead
  2. multiGc ginkgo label addition
  3. TKG controller namespace change as it depend on testbed cluster name now.

Testing done:
YES - https://gist.github.com/rajguptavm/71024fb66fab67b79f9b61643f111404
pre-checkin pipeline result - https://gist.github.com/rajguptavm/96cf6f7d59e561b839802e819e6667c1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rajguptavm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2025
@ravikumarkp7
Copy link

ok-to-test

@deepakkinni
Copy link
Collaborator

Triggering CSI-FVT Jenkins Job... Please wait for 1min for the pipeline to complete
Jenkins Build #5

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #5

@ravikumarkp7
Copy link

ok-to-test-tkg

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #190

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #197

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #198

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #199

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #198

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #199

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #200

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #201

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #201

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #202

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #202

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #207

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #207

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #211

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #213

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #211

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #214

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #214

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #216

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #216

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #100

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #100

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #102

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #103

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #3

kirankumarbasavaraju-broadcom
kirankumarbasavaraju-broadcom reviewed Aug 25, 2025
View reviewed changes
@anuj087
Copy link
Contributor

anuj087 commented Aug 26, 2025

Please update testing done section and put a brief summary about the issue and fix.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2025
Aishwarya-Hebbar
Aishwarya-Hebbar suggested changes Aug 28, 2025
View reviewed changes
@Aishwarya-Hebbar
Copy link
Contributor

Please run precheckin tests before merging the PR.

Approving ahead.

@Aishwarya-Hebbar
Copy link
Contributor

/approve

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #202

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #207

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #217

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #334

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #334

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #231

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #335

@kavyashree-r
Copy link
Contributor

/approve
/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aishwarya-Hebbar, kavyashree-r, rajguptavm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5320628 into kubernetes-sigs:master Aug 30, 2025
11 checks passed
@rajguptavm rajguptavm deleted the tkg-win-test-fix branch September 1, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

@sipriyaa sipriyaa Awaiting requested review from sipriyaa

2 more reviewers

@kirankumarbasavaraju-broadcom kirankumarbasavaraju-broadcom kirankumarbasavaraju-broadcom left review comments

@Aishwarya-Hebbar Aishwarya-Hebbar Aishwarya-Hebbar requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kavyashree-r kavyashree-r

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rajguptavm @k8s-ci-robot @ravikumarkp7 @deepakkinni @bn023052 @anuj087 @Aishwarya-Hebbar @kavyashree-r @kirankumarbasavaraju-broadcom