Skip to content

Conversation

Aishwarya-Hebbar
Copy link
Contributor

@Aishwarya-Hebbar Aishwarya-Hebbar commented Jul 16, 2025

What this PR does / why we need it: This enhancement has been introduced to improve the testing framework for CSI driver by enabling support for diverse user personas.

Specifically, the updated framework is designed to simulate and validate workflows from the perspective of key personas such as DevOps users and administrator users.

This change includes:

  1. Running tests on WCP with supervisor administrator and supervisor devops user.
  2. Running tests on GC with GC administrator, GC devops user and supervisor administrator.
  3. A new util WaitForPVClaimBoundPhase is introduced to support passing both administrator and devops client.
  4. Modified CreateTestWCpNS function to create namespace with permission to devops user as namespace owner.
  5. To use deleteAllStsAndPodsPVCsInNamespace instead of fss.DeleteAllStatefulsets to pass the devops client as required.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
https://gist.github.com/Aishwarya-Hebbar/e89c9fa66f9272fe4cceeaab553ed33d

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aishwarya-Hebbar
Once this PR has been reviewed and has the lgtm label, please assign kavyashree-r for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Aishwarya-Hebbar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 16, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the csi_testing_with_diff_personas branch 16 times, most recently from e56d511 to 80f0ffe Compare July 22, 2025 15:39
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the csi_testing_with_diff_personas branch from 80f0ffe to d1709f8 Compare July 24, 2025 09:43
@Aishwarya-Hebbar Aishwarya-Hebbar changed the title [WIP]CSI testing with different personas CSI testing with different personas Jul 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the csi_testing_with_diff_personas branch 3 times, most recently from e1b9827 to 663e814 Compare July 26, 2025 15:47
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the csi_testing_with_diff_personas branch 24 times, most recently from 59ec122 to 92a416c Compare August 12, 2025 16:05
@kavyashree-r
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@Aishwarya-Hebbar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-verify-golangci-lint 92a416c link true /test pull-vsphere-csi-driver-verify-golangci-lint
pull-vsphere-csi-driver-verify-staticcheck 92a416c link true /test pull-vsphere-csi-driver-verify-staticcheck
pull-vsphere-csi-driver-unit-test 92a416c link true /test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the csi_testing_with_diff_personas branch from 92a416c to 5dcdba8 Compare September 1, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants