Remove all references to WCP_VMService_BYOK FSS

[nikolay-andreev]

What this PR does / why we need it:
Remove WCP_VMService_BYOK feature flag from the codebase once it has been removed from vCenter.

Testing done:
Platform Scale/Perf Testing.

Special notes for your reviewer:
To be merged once FSS flag is fully removed from vCenter.

[k8s-ci-robot]

Hi @nikolay-andreev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[divyenpatel]

/ok-to-test

[divyenpatel]

Can we make sure code for BYOK is only executed for wcp supervisor?
I think we are not supporting this feature on vanilla deployment yet.
CreateBlockVolumeUtil is shared with vanilla flavor.

[k8s-ci-robot]

@nikolay-andreev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-vsphere-csi-driver-unit-test	8066399	link	true	/test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[divyenpatel]

if vCenter is older and if we upgrade supervisor to latest, can removal of this FSS cause any issue?
Generally we guard feature with some capability check to ensure no regression for such upgrade?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikolay-andreev

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment