Skip to content

multi-Svc test refactor #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

multi-Svc test refactor #3469

merged 1 commit into from
Aug 29, 2025
+460 −227

Conversation

rajguptavm
Copy link
Contributor

@rajguptavm rajguptavm commented Aug 5, 2025 •
edited
Loading

What this PR does / why we need it:
Multi-Svc Test refactor as per new refactored csi-driver test repo

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Code-Refactor for CSI e2e tests

Testing done:
DONE - https://gist.github.com/rajguptavm/4d90c565adbc63e3e30549b170f12961

Special notes for your reviewer:
@anuj087 @kavyashree-r Please review it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rajguptavm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 5, 2025
@ravikumarkp7
Copy link

ok-to-test-tkg

@ravikumarkp7
Copy link

ok-to-test-wcp

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #48

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #48

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #232

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #93

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #250

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #251

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #2

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #2

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 22, 2025
kavyashree-r
kavyashree-r reviewed Aug 25, 2025
View reviewed changes
@kavyashree-r
Copy link
Contributor

/ok-to-test-wcp

anuj087
anuj087 approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@anuj087 anuj087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Since you are modifying run-e2e-test.sh, Please make sure we dont break any pipeline!

ravikumarkp7
ravikumarkp7 approved these changes Aug 28, 2025
View reviewed changes
Copy link

@ravikumarkp7 ravikumarkp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2025
@kavyashree-r
Copy link
Contributor

/approve

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #201

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #203

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #203

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #206

@kavyashree-r
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuj087, bn023052, kavyashree-r, rajguptavm, ravikumarkp7
Once this PR has been reviewed and has the lgtm label, please assign chethanv28 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kavyashree-r
Copy link
Contributor

/LGTM

@kavyashree-r
Copy link
Contributor

/lgtm

@chethanv28 chethanv28 merged commit 44c8987 into kubernetes-sigs:master Aug 29, 2025
11 of 12 checks passed
chethanv28
chethanv28 reviewed Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

nikhilbarge pushed a commit to nikhilbarge/vsphere-csi-driver that referenced this pull request Aug 29, 2025
@rajguptavm @nikhilbarge
multi-Svc test refactor (kubernetes-sigs#3469)
adcb5bc
k8s-ci-robot pushed a commit that referenced this pull request Aug 29, 2025
@nikhilbarge @deepakkinni
@Aishwarya-Hebbar @xing-yang @divyenpatel @rajguptavm
Cherry-Pick commits upto daee8bd (#3518)
a2484ff 
* Fix IsLinkedCloneRequest to use FSS based on cluster flavor (#3512)

Signed-off-by: Deepak Kinni <[email protected]>

* Utils for CSI personas testing (#3494)

* Check topology annotation on existing PVC for CnsRegisterVolume (#3489)

* Check topology annotation on existing PVC for CNSRegisterVolume

* Move the PVC check before PV creation

* Removed commented out code

* Address comments

* use supports_FCD_transaction wcp capability to enabled transaction support (#3509)

* set max back off duration for reconcilers (#3510)

* Update CSI spec dependency (#3511)

Signed-off-by: Deepak Kinni <[email protected]>

* multi-Svc test refactor (#3469)

* Improve capabilities check for case when TKR is newer than supervisor (#3514)

---------

Signed-off-by: Deepak Kinni <[email protected]>
Co-authored-by: Deepak Kinni <[email protected]>
Co-authored-by: Aishwarya-Hebbar <[email protected]>
Co-authored-by: Xing Yang <[email protected]>
Co-authored-by: Divyen Patel <[email protected]>
Co-authored-by: Raj Kumar Gupta <[email protected]>
@rajguptavm rajguptavm deleted the test-refactor branch September 1, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chethanv28 chethanv28 chethanv28 left review comments

@sipriyaa sipriyaa Awaiting requested review from sipriyaa

+4 more reviewers

@kavyashree-r kavyashree-r kavyashree-r left review comments

@ravikumarkp7 ravikumarkp7 ravikumarkp7 approved these changes

@anuj087 anuj087 anuj087 approved these changes

@bn023052 bn023052 bn023052 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kavyashree-r kavyashree-r

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rajguptavm @k8s-ci-robot @ravikumarkp7 @deepakkinni @kavyashree-r @chethanv28 @anuj087 @bn023052