Skip to content

RWX VMService VM testcases and utils automation #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RWX VMService VM testcases and utils automation #3476

wants to merge 1 commit into from
+3,111 −7

Conversation

Aishwarya-Hebbar
Copy link
Contributor

@Aishwarya-Hebbar Aishwarya-Hebbar commented Aug 7, 2025 •
edited
Loading

What this PR does / why we need it: Utils and testcases required RWX support with VMService VM.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
https://gist.github.com/Aishwarya-Hebbar/7c8241b9218eec9dffdb0a95b940796c

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Aishwarya-Hebbar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 7, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the rwx-support-VmService-part1 branch 2 times, most recently from 48eb56a to 8fec1f4 Compare August 8, 2025 04:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the rwx-support-VmService-part1 branch from 8fec1f4 to 104ebf4 Compare September 1, 2025 09:28
@Aishwarya-Hebbar Aishwarya-Hebbar changed the title [WIP]RWX VMService VM testcases and utils automation RWX VMService VM testcases and utils automation Sep 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2025
@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the rwx-support-VmService-part1 branch from 104ebf4 to dec564d Compare September 1, 2025 10:00
rajguptavm
rajguptavm reviewed Sep 1, 2025
View reviewed changes
hack/run-e2e-test.sh Outdated
@@ -73,7 +73,7 @@ then
OPTS+=(-p)
ginkgo -mod=mod "${OPTS[@]}" --focus="csi-block-vanilla-parallelized" tests/e2e
else
ginkgo -mod=mod "${OPTS[@]}" --focus="$FOCUS" tests/e2e
ginkgo -mod=mod "${OPTS[@]}" --focus="$FOCUS" -r tests/e2e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, already merged.

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the rwx-support-VmService-part1 branch from dec564d to baa204d Compare September 3, 2025 11:08
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aishwarya-Hebbar
Once this PR has been reviewed and has the lgtm label, please assign sipriyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chethanv28 chethanv28 Awaiting requested review from chethanv28

@sipriyaa sipriyaa Awaiting requested review from sipriyaa

1 more reviewer

@rajguptavm rajguptavm rajguptavm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aishwarya-Hebbar @k8s-ci-robot @rajguptavm