Skip to content

reduce replica of vsphere-csi-controller and vsphere-csi-webhook to two #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

reduce replica of vsphere-csi-controller and vsphere-csi-webhook to two #3478

merged 1 commit into from
Aug 14, 2025

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Aug 8, 2025 •
edited
Loading

What this PR does / why we need it:
This PR is reducing replica of vSphere CSI controller and vSphere CSI webhook to two.

This PR also sync manifests/supervisorcluster/1.29/cns-csi.yaml with manifests/supervisorcluster/1.32/cns-csi.yaml

Reason:
Currently, we have 3 replica for CSI controller pod. We do not have any quorum requirement or need to spread replica on all CP VMs, so we can consider reducing replica of deployment 2.

all CSI sidecars and syncer has leader-election, and depending on the side car replica leadership, CSI controller is getting request for volume life cycle operations.

reducing replica also helps with reducing VC session requirements.

Testing done:
Applied YAML file manually on the testbed deployed from main
No issue observed.

Special notes for your reviewer:

Release note:

@divyenpatel divyenpatel requested a review from chethanv28 August 8, 2025 21:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2025
akankshapanse
akankshapanse reviewed Aug 11, 2025
View reviewed changes
@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #76

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #76

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #77

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #84

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #245

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #84

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #245

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #246

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #246

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #97

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #101

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #97

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #105

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #108

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #105

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #111

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #111

@divyenpatel
Copy link
Member Author

ok-to-test-wcp

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #121

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #121

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #122

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #140

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #141

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #140

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #143

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #145

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #146

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #145

chethanv28
chethanv28 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline to replace yamls is in works. Based on the manual testing results, merging this PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a27467 into kubernetes-sigs:master Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chethanv28 chethanv28 chethanv28 approved these changes

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

+1 more reviewer

@akankshapanse akankshapanse akankshapanse left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@chethanv28 chethanv28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyenpatel @deepakkinni @k8s-ci-robot @chethanv28 @akankshapanse