Skip to content

Enhancement - Keep active VC session alive #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Enhancement - Keep active VC session alive #3479

merged 1 commit into from
Aug 15, 2025

Conversation

kolluria
Copy link
Contributor

@kolluria kolluria commented Aug 9, 2025 •
edited
Loading

What this PR does / why we need it:

We have noticed in both customer environments and in internal testing, that some times a VC session which is actively in use is terminated abruptly. This causes the CSI Driver to reload the configuration and establish a new session which is inefficient. Ideally, a session should remain active as long as it's in active use.

This PR introduces a one-liner that essentially adds the Keep Alive functionality to the session to ensure that an active session isn't terminated.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Successful regression run - #3479 (comment)

Special notes for your reviewer:

Release note:

Enhance VC client to keep session active

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2025
@kolluria kolluria changed the title Added session Keep Alive logic Enhancement - Keep active VC session alive Aug 9, 2025
@kolluria kolluria marked this pull request as ready for review August 9, 2025 14:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2025
@kolluria
Copy link
Contributor Author

kolluria commented Aug 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 9, 2025
@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #234

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #236

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #236

@deepakkinni
Copy link
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #237

@deepakkinni
Copy link
Collaborator

FAILED --- Jenkins Build #238

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #83

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #83

@kolluria
Copy link
Contributor Author

/cc @divyenpatel @deepakkinni @johnchobroadcom

@k8s-ci-robot
Copy link
Contributor

@kolluria: GitHub didn't allow me to request PR reviews from the following users: johnchobroadcom.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @divyenpatel @deepakkinni @johnchobroadcom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kolluria
Copy link
Contributor Author

/assign @kolluria

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #92

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #96

@deepakkinni
Copy link
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #107

@deepakkinni
Copy link
Collaborator

SUCCESS --- Jenkins Build #107

divyenpatel
divyenpatel approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, kolluria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [divyenpatel,kolluria]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kolluria
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5c3d342 into kubernetes-sigs:master Aug 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

@gnufied gnufied Awaiting requested review from gnufied

@akankshapanse akankshapanse Awaiting requested review from akankshapanse

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@divyenpatel divyenpatel

@kolluria kolluria

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolluria @k8s-ci-robot @deepakkinni @divyenpatel