-
Notifications
You must be signed in to change notification settings - Fork 199
Add file share export paths to volume attributes so that CSI provisioner can add them as PVC annotations #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add file share export paths to volume attributes so that CSI provisioner can add them as PVC annotations #3629
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vdkotkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d509325
to
8fbd987
Compare
8fbd987
to
98a961b
Compare
/ok-to-test |
98a961b
to
a9edeaf
Compare
…ner can add them as PVC annotations
a9edeaf
to
fe6c644
Compare
What this PR does / why we need it:
This PR takes care of following things:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
Create a file PVC with these changes and verified that file share export paths are added as PVC annotations.
CSI controller logs:
CSI provisioner logs:
To test fullsync changes, manually edited PVC to remove file share export path annotations from PVC and verified that fullsync added back those annotations.
Syncer logs:
Special notes for your reviewer:
Release note: