-
Notifications
You must be signed in to change notification settings - Fork 199
Block RWX volume creation for VMFS datastores if policy is not EZT #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Block RWX volume creation for VMFS datastores if policy is not EZT #3729
Conversation
|
Hi @skogta. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4a89584 to
e56f945
Compare
caf55d9 to
abfb84f
Compare
|
/ok-to-test |
abfb84f to
30da00f
Compare
divyenpatel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, skogta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
30da00f to
d52d9ca
Compare
|
/retest-required |
8ec1120 to
1d2aff0
Compare
e998c2f to
6cb9fea
Compare
bb4e133 to
7e139b1
Compare
7e139b1 to
7e0ce64
Compare
What this PR does / why we need it:
Add a validation in CSI to fail RWX volume creation if policy is for VMFS datastores and is NOT EZT.
This is a requirement for multiwriter.
Testing done:
DYNAMIC:
Created RWX volume with vSAN policy - reached Bound state.
Created RWX volume with VMFS EZT policy - reached Bound state.
Created RWX volume with VMFS non-EZT policy - stayed in Pending state. See below:
Created RWXOvolume with vSAN policy - reached Bound state.
Created RWO volume with VMFS EZT policy - reached Bound state.
Created RWO volume with VMFS non-EZT policy - reached Bound state.
STATIC:
Create RWX volume with vSAN policy - PVC and PV got created.
Create RWX volume with VMFS EZT policy - PVC and PV got created.
Create RWX volume with VMFS non-EZT policy - PVC and PV failed o get created. Error:
Pre-checkin pipelines are in progress.