Skip to content

Set error code to indicate timeout in pvCSI #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

Set error code to indicate timeout in pvCSI #3763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/csi/service/wcpguest/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,11 @@ func (c *controller) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequ

log.Errorf("Last observed events on the pvc %q/%q in supervisor cluster: %+v",
c.supervisorNamespace, pvc.Name, spew.Sdump(eventList.Items))
return nil, csifault.CSIInternalFault, status.Error(codes.Internal, msg)
// Note: Set the return code to codes.DeadlineExceeded if PVC is still not bound
// to indicate that the volume provisioning has timed out
// so that external-provisioner will keep retrying and won't leave
// orphan volumes behind.
return nil, csifault.CSIInternalFault, status.Error(codes.DeadlineExceeded, msg)
}
attributes := make(map[string]string)
if commonco.ContainerOrchestratorUtility.IsFSSEnabled(ctx, common.FileVolume) && isFileVolumeRequest {
Expand Down
Loading