s

Signed-off-by: Omer Aplatony <[email protected]>

Author: omerap12

vertical-pod-autoscaler/pkg/updater/logic/updater.go

@@ -167,8 +167,7 @@ func (u *updater) RunOnce(ctx context.Context) {
 
 	inPlaceFeatureEnable := features.Enabled(features.InPlaceOrRecreate)
 
-	var podsList []*apiv1.Pod
-	seenPods := sets.New[string]()
+	seenPods := sets.New[*apiv1.Pod]()
 
 	for _, vpa := range vpaList {
 		if slices.Contains(u.ignoredNamespaces, vpa.Namespace) {
@@ -197,10 +196,7 @@ func (u *updater) RunOnce(ctx context.Context) {
 
 		// handle the case of overlapping VPA selectors
 		for _, pod := range podsWithSelector {
-			if !seenPods.Has(pod.Name) {
-				seenPods.Insert(pod.Name)
-				podsList = append(podsList, pod)
-			}
+			seenPods.Insert(pod)
 		}
 
 		vpas = append(vpas, &vpa_api_util.VpaWithSelector{
@@ -218,7 +214,7 @@ func (u *updater) RunOnce(ctx context.Context) {
 	}
 
 	timer.ObserveStep("ListPods")
-	allLivePods := filterDeletedPods(podsList)
+	allLivePods := filterDeletedPodsFromSet(seenPods)
 
 	controlledPods := make(map[*vpa_types.VerticalPodAutoscaler][]*apiv1.Pod)
 	for _, pod := range allLivePods {
@@ -403,10 +399,14 @@ func filterNonEvictablePods(pods []*apiv1.Pod, evictionRestriction restriction.P
 	return filterPods(pods, evictionRestriction.CanEvict)
 }
 
-func filterDeletedPods(pods []*apiv1.Pod) []*apiv1.Pod {
-	return filterPods(pods, func(pod *apiv1.Pod) bool {
-		return pod.DeletionTimestamp == nil
-	})
+func filterDeletedPodsFromSet(pods sets.Set[*apiv1.Pod]) []*apiv1.Pod {
+	result := make([]*apiv1.Pod, 0)
+	for p := range pods {
+		if p.DeletionTimestamp == nil {
+			result = append(result, p)
+		}
+	}
+	return result
 }
 
 func newPodLister(kubeClient kube_client.Interface, namespace string) v1lister.PodLister {