Skip to content

Commit 97d1b55

Browse files
authored
Merge pull request #8719 from adrianmoisey/more-with-serial
Guard a few more e2e tests with WithSerial()
2 parents ed74077 + 96f3704 commit 97d1b55

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

vertical-pod-autoscaler/e2e/v1/recommender.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,8 @@ var _ = utils.RecommenderE2eDescribe("VPA CRD object", func() {
241241
gomega.Expect(err).NotTo(gomega.HaveOccurred())
242242
})
243243

244-
ginkgo.It("doesn't drop lower/upper after recommender's restart", func() {
244+
// FIXME todo(adrianmoisey): This test seems to be flaky after running in parallel, unsure why, see if it's possible to fix
245+
framework.It("doesn't drop lower/upper after recommender's restart", framework.WithSerial(), func() {
245246

246247
o := getVpaObserver(vpaClientSet, f.Namespace.Name)
247248

vertical-pod-autoscaler/e2e/v1/updater.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
134134
ginkgo.By(fmt.Sprintf("Waiting for pods to be evicted, hoping it won't happen, sleep for %s", VpaEvictionTimeout.String()))
135135
CheckNoPodsEvicted(f, MakePodSet(podList))
136136
})
137-
138-
ginkgo.It("doesn't evict pods when Admission Controller status unavailable", func() {
137+
// FIXME todo(adrianmoisey): This test seems to be flaky after running in parallel, unsure why, see if it's possible to fix
138+
framework.It("doesn't evict pods when Admission Controller status unavailable", framework.WithSerial(), func() {
139139
podList := setupPodsForUpscalingEviction(f)
140140

141141
ginkgo.By(fmt.Sprintf("Waiting for pods to be evicted, hoping it won't happen, sleep for %s", VpaEvictionTimeout.String()))

0 commit comments

Comments
 (0)