use Set only

Signed-off-by: Omer Aplatony <[email protected]>

Author: omerap12

vertical-pod-autoscaler/pkg/updater/logic/updater.go

@@ -26,7 +26,6 @@ import (
 	apiv1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/fields"
 	"k8s.io/apimachinery/pkg/labels"
-	"k8s.io/apimachinery/pkg/util/sets"
 	kube_client "k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/kubernetes/fake"
 	corescheme "k8s.io/client-go/kubernetes/scheme"
@@ -167,8 +166,7 @@ func (u *updater) RunOnce(ctx context.Context) {
 
 	inPlaceFeatureEnable := features.Enabled(features.InPlaceOrRecreate)
 
-	var podsList []*apiv1.Pod
-	seenPods := sets.New[string]()
+	seenPods := make(map[string]*apiv1.Pod)
 
 	for _, vpa := range vpaList {
 		if slices.Contains(u.ignoredNamespaces, vpa.Namespace) {
@@ -197,9 +195,8 @@ func (u *updater) RunOnce(ctx context.Context) {
 
 		// handle the case of overlapping VPA selectors
 		for _, pod := range podsWithSelector {
-			if !seenPods.Has(pod.Name) {
-				seenPods.Insert(pod.Name)
-				podsList = append(podsList, pod)
+			if _, exists := seenPods[pod.Name]; !exists {
+				seenPods[pod.Name] = pod
 			}
 		}
 
@@ -218,7 +215,7 @@ func (u *updater) RunOnce(ctx context.Context) {
 	}
 
 	timer.ObserveStep("ListPods")
-	allLivePods := filterDeletedPods(podsList)
+	allLivePods := filterDeletedPodsFromMap(seenPods)
 
 	controlledPods := make(map[*vpa_types.VerticalPodAutoscaler][]*apiv1.Pod)
 	for _, pod := range allLivePods {
@@ -403,10 +400,14 @@ func filterNonEvictablePods(pods []*apiv1.Pod, evictionRestriction restriction.P
 	return filterPods(pods, evictionRestriction.CanEvict)
 }
 
-func filterDeletedPods(pods []*apiv1.Pod) []*apiv1.Pod {
-	return filterPods(pods, func(pod *apiv1.Pod) bool {
-		return pod.DeletionTimestamp == nil
-	})
+func filterDeletedPodsFromMap(podsMap map[string]*apiv1.Pod) []*apiv1.Pod {
+	result := make([]*apiv1.Pod, 0, len(podsMap))
+	for _, pod := range podsMap {
+		if pod.DeletionTimestamp == nil {
+			result = append(result, pod)
+		}
+	}
+	return result
 }
 
 func newPodLister(kubeClient kube_client.Interface, namespace string) v1lister.PodLister {