-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add csinode limit awareness in cluster-autoscaler #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c6d08e7 to
c26409b
Compare
|
@mtrqq Could you do a first-pass review here? This is supposed to follow the way that DRA integration was implemented in CA as much as possible, but instead of the DRA objects we have |
10b6319 to
18906a8
Compare
48c0b28 to
2a287f3
Compare
|
@mtrqq yes, the PR is ready for review. It was marked WIP, because I had to keep rebasing it and I had to make bunch of changes because of latest kube rebase. Even the tests that are still failing are most likely unrelated to this change and are happening because of kube version bump. |
2a287f3 to
2811f12
Compare
2811f12 to
e673a9b
Compare
Bump vendor dependencies for latest k8s master
Fix code to use new framework
e673a9b to
dd1da1e
Compare
|
@gnufied: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
xref - kubernetes/enhancements#5030
This makes CAS aware of volume limits on new nodes when scaling for pending pods.
This includes relevant changes in k/k repo from - https://github.com/gnufied/kubernetes/tree/volume-limits-redux-cas
But I have tested the changes together and they work fine.