Skip to content

Making CapacityBuffer ProvisioningStrategy a string (not enum) #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −3
Draft

Making CapacityBuffer ProvisioningStrategy a string (not enum) #8832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cluster-autoscaler/apis/capacitybuffer/autoscaling.x-k8s.io/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ type ResourceList map[ResourceName]resource.Quantity
type CapacityBufferSpec struct {
// ProvisioningStrategy defines how the buffer is utilized.
// "buffer.x-k8s.io/active-capacity" is the default strategy, where the buffer actively scales up the cluster by creating placeholder pods.
// +kubebuilder:validation:Enum=buffer.x-k8s.io/active-capacity
// +kubebuilder:default="buffer.x-k8s.io/active-capacity"
// +optional
ProvisioningStrategy *string `json:"provisioningStrategy,omitempty" protobuf:"bytes,1,opt,name=provisioningStrategy"`
Expand Down
2 changes: 0 additions & 2 deletions cluster-autoscaler/apis/config/crd/autoscaling.x-k8s.io_capacitybuffers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ spec:
description: |-
ProvisioningStrategy defines how the buffer is utilized.
"buffer.x-k8s.io/active-capacity" is the default strategy, where the buffer actively scales up the cluster by creating placeholder pods.
enum:
- buffer.x-k8s.io/active-capacity
type: string
replicas:
description: |-
Expand Down