Enhancement/Bug Fix: Update OCI provider nodepool and error propagation and tests

[lxuan94-pp]

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

This PR improves how the OCI Provider handles node errors.

• OOC/LimitExceeded nodes (without instance IDs) and OKE InstanceCreating placeholder nodes should not be expected to register in the cluster and should be excluded from the expectedToRegister flow. (see the expectedToRegister flow in clusterstate.go), they should be handled in fixNodeGroupSize flow

• Nodes with instance IDs (e.g., registration timeouts & NPN errors) are handled in deleteCreatedNodesWithErrors.

• ErrorInfo is set when:

  • The node has an OKE NodeError and exceeds maxNodeProvisionTime.
  • The node is Updating and exceeds maxNodeProvisionTime without an OKE error, in which case a default timeout error is applied.

Since DECREASE_TARGET_CHECK_VIA_COMPUTE needs to call Compute, and this is not recommended in production per our discussion offline, this PR can handle OOC/LimitExceeded nodes without using the variable and additional calls.

This behavior is consistent with the intended autoscaler core logic.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

The change has been released in production for several months[https://bitbucket.oci.oraclecorp.com/projects/OMK/repos/autoscaler/pull-requests/6/overview] and has achieved stable scaling behavior based on the customer set timeout.

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lxuan94-pp
Once this PR has been reviewed and has the lgtm label, please assign jlamillan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/oci/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @lxuan94-pp. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

/assign @jlamillan