Skip to content

provide an option to use eks.amazonaws.com/role-arn annotation instead of eks.amazonaws.com/ecr-role-arn #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −3
Open

provide an option to use eks.amazonaws.com/role-arn annotation instead of eks.amazonaws.com/ecr-role-arn #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c5a2f
feat: enhance ECR role ARN retrieval from service account annotations
bear-san Sep 28, 2025
f655bf2
Merge pull request #1 from bear-san/feature/support-irsa-annotation
bear-san Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cmd/ecr-credential-provider/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,15 @@ func (e *ecrPlugin) getPrivateCredsData(ctx context.Context, imageHost string, i
func (e *ecrPlugin) buildCredentialsProvider(ctx context.Context, request *v1.CredentialProviderRequest, imageHost string) (aws.CredentialsProvider, error) {
var err error

arn, ok := request.ServiceAccountAnnotations["eks.amazonaws.com/ecr-role-arn"]
if !ok {
arn = os.Getenv("AWS_ECR_ROLE_ARN")
var arn string
if candidateARN, ok := request.ServiceAccountAnnotations["eks.amazonaws.com/ecr-role-arn"]; ok {
arn = candidateARN
} else if candidateARN, ok = os.LookupEnv("AWS_ECR_ROLE_ARN"); ok {
arn = candidateARN
} else if candidateARN, ok = request.ServiceAccountAnnotations["eks.amazonaws.com/role-arn"]; ok {
arn = candidateARN
}

if arn == "" {
return nil, errors.New("no arn provided, cannot assume role using ServiceAccountToken")
}
Expand Down