Update openstack-cinder-csi helm chart for multi cloud support

[guillaumebernard84]

What this PR does / why we need it:

Hello, this PR modifies the openstack-cinder-csi helm chart to allow to use it with the multi cloud feature: #2551

It fixes two problems that were preventing to use the chart with multi cloud:

1. When runing the cinder-csi-plugin with multi-region, you need to specify different extraArgs on the cinder-csi-plugin containers of the deployment and the daemonset. It wasn't possible with the current version. Now you can, like this:

nodePlugin:
  extraArgs: |-
    - --cloud-name=region-one
    - --additional-topology
    - topology.kubernetes.io/region=region-one
controllerPlugin:
  extraArgs: |-
    - --cloud-name=region-one
    - --cloud-name=region-two

You still need to create the second daemonset manually, but at least you can use the chart. If this PR is accepted, I'll work on a new one to allow the creation of the second daemonset.

2. If you use the resizer and the snapshotter, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. This was hardcoded in controllerplugin-rbac.yaml, now you can specify it like this:

snapshotter:
  extraRbac:
    - apiGroups: [""]
      resources: ["secrets"]
      verbs: ["get", "list"]
resizer:
  extraRbac:
    - apiGroups: [""]
      resources: ["secrets"]
      verbs: ["get", "list", "watch"]

I also moved the comments from controllerplugin-rbac.yaml to the values file.

I added these info to the multi-region-clouds.md documentation file.

Release note:

[openstack-cinder-csi] Helm chart now supports multi regions/clouds

[k8s-ci-robot]

Hi @guillaumebernard84. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pabclsn]

Hi @guillaumebernard84 could you rebase your PR I'd love to use your work thanks in advance ;)

[guillaumebernard84]

Hi @guillaumebernard84 could you rebase your PR I'd love to use your work thanks in advance ;)

Rebased!

[pabclsn]

I think the project is moving too fast x) You should rebase every 10 minutes

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[guillaumebernard84]

/remove-lifecycle stale

[guillaumebernard84]

Rebased again!

[guillaumebernard84]

Up!
The linter wants me to bump the chart version, but that causes "PR needs rebase" as the helm chart is regularly updated by other PR. Whats should I do?

[kayrus]

rebase and use +1 from the master branch value.

[kayrus]

/lgtm
/approve

Thank you! Apologies for the long wait

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kayrus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[guillaumebernard84]

Thank you very much @kayrus !