Skip to content

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 11, 2025

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

for some reason this change was implemented too soon https://github.blog/changelog/2025-02-18-github-issues-projects-february-18th-update/#single-issue-templates-issue_template-md-will-be-retired

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2025
@k8s-ci-robot k8s-ci-robot requested review from mdbooth and zetaab March 11, 2025 10:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 11, 2025
@kayrus
Copy link
Contributor Author

kayrus commented Mar 11, 2025

@dulek
Copy link
Contributor

dulek commented Mar 12, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2fb6715 into master Mar 12, 2025
4 checks passed
@Boston01
Copy link
Contributor

Hi @kayrus i put you as a reviewer for this pull request can you have a look on it #2843

@stephenfin
Copy link
Member

/cherry-pick release-1.32

...for the golangci-lint change to address issues seen in #2871 but the "main" change is no harm

@k8s-infra-cherrypick-robot

@stephenfin: new pull request created: #2873

In response to this:

/cherry-pick release-1.32

...for the golangci-lint change to address issues seen in #2871 but the "main" change is no harm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stephenfin
Copy link
Member

/cherry-pick release-1.31

per above

@k8s-infra-cherrypick-robot

@stephenfin: new pull request created: #2874

In response to this:

/cherry-pick release-1.31

per above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants