Skip to content

[cinder-csi-plugin] Use context #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 4 commits into from
Oct 10, 2025
Merged

[cinder-csi-plugin] Use context #2864

k8s-ci-robot merged 4 commits into from
Oct 10, 2025
+16 −12

Conversation

@stephenfin
Copy link
Member

@stephenfin stephenfin commented Mar 24, 2025

What this PR does / why we need it:

Use the generated VolumeContext.

Which issue this PR fixes(if applicable):
fixes #2863

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from mdbooth and zetaab March 24, 2025 18:01
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2025
@stephenfin
Copy link
Member Author

stephenfin commented Mar 24, 2025

/cc @kayrus

...again since #2743 was your PR so I'd like to make sure I'm not missing anything obvious 😅

@k8s-ci-robot k8s-ci-robot requested a review from kayrus March 24, 2025 18:02
@mandre
Copy link
Contributor

mandre commented Apr 7, 2025

/cc @kayrus

...again since #2743 was your PR so I'd like to make sure I'm not missing anything obvious 😅

I think you meant #2687, where volCtx was introduced but never used.

mandre
mandre reviewed Apr 7, 2025
View reviewed changes
mandre
mandre reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 23, 2025
kayrus
kayrus reviewed Oct 2, 2025
View reviewed changes
@kayrus
Copy link
Contributor

kayrus commented Oct 8, 2025

@stephenfin would you like to ship this in 1.34?

@kayrus kayrus mentioned this pull request Oct 8, 2025
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2025
@stephenfin
Copy link
Member Author

stephenfin commented Oct 8, 2025

@stephenfin would you like to ship this in 1.34?

I don't think it's critical, but it would be good to include, yes. I've addressed your comment now (sorry I missed it earlier).

kayrus
kayrus reviewed Oct 9, 2025
View reviewed changes
@stephenfin
cinder-csi-plugin: Use generated VolumeContext
cfe4e31 
Looks like an oversight in commit 7bfb2eb.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
trivial: Explain overloaded context term
91ba576 
This confused me. It might confuse others.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
trivial: camelCase variable name
87d670c 
Signed-off-by: Stephen Finucane <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
kayrus
kayrus approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9c52213 into kubernetes:master Oct 10, 2025
6 checks passed
@stephenfin stephenfin deleted the cinder-context branch October 10, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayrus kayrus kayrus approved these changes

@mdbooth mdbooth Awaiting requested review from mdbooth

@zetaab zetaab Awaiting requested review from zetaab

+1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@kayrus kayrus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Volume context is not used

4 participants

@stephenfin @mandre @kayrus @k8s-ci-robot